Code Review for 3317-dis-cross-target

Prepared by:Jeff (jeffpc) on 2014-Jul-29 20:47 -0400 EDT
Workspace:/home/jeffpc/illumos/cross-dis (at 8d9e9741a407)
Compare against: master (at 63e911b6fce0)
Summary of changes: 982 lines changed: 517 ins; 318 del; 147 mod; 7193 unchg
Patch of changes: 3317-dis-cross-target.patch
Printable review: 3317-dis-cross-target.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_main.c

3317 dis(1) should support cross-target disassembly
29 lines changed: 19 ins; 5 del; 5 mod; 710 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.c

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 976 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.h

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.com

3317 dis(1) should support cross-target disassembly
45 lines changed: 19 ins; 11 del; 15 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.targ

3317 dis(1) should support cross-target disassembly
5 lines changed: 0 ins; 5 del; 0 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/amd64/Makefile

3317 dis(1) should support cross-target disassembly
3 lines changed: 2 ins; 1 del; 0 mod; 36 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdisasm/common/dis_i386.c

3317 dis(1) should support cross-target disassembly
259 lines changed: 259 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.c)

3317 dis(1) should support cross-target disassembly
95 lines changed: 39 ins; 23 del; 33 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.h)

3317 dis(1) should support cross-target disassembly
13 lines changed: 0 ins; 8 del; 5 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.c)

3317 dis(1) should support cross-target disassembly
98 lines changed: 20 ins; 0 del; 78 mod; 2676 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.h)

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 122 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_instr.c (renamed from usr/src/lib/libdisasm/sparc/instr.c)

3317 dis(1) should support cross-target disassembly
0 lines changed: 0 ins; 0 del; 0 mod; 1701 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.c

3317 dis(1) should support cross-target disassembly
128 lines changed: 126 ins; 2 del; 0 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.h

3317 dis(1) should support cross-target disassembly
18 lines changed: 7 ins; 0 del; 11 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm_impl.h

3317 dis(1) should support cross-target disassembly
25 lines changed: 23 ins; 2 del; 0 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/mapfile-vers

3317 dis(1) should support cross-target disassembly
1 line changed: 1 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/i386/Makefile

3317 dis(1) should support cross-target disassembly
3 lines changed: 2 ins; 1 del; 0 mod; 35 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libdisasm/i386/dis_i386.c (deleted)

3317 dis(1) should support cross-target disassembly
254 lines changed: 0 ins; 254 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.