Code Review for 5253-kmem_alloc-kmem_zalloc-wont-fail-with-KM_SLEEP

Prepared by: (jeffpc) on 2014-Oct-23 11:05 -0400 EDT
Workspace:/home/jeffpc/illumos/spatch (at d8eb8859bd8b)
Compare against: HEAD^ (at a05fd0c9b9aa)
Summary of changes: 438 lines changed: 0 ins; 414 del; 24 mod; 142343 unchg
Patch of changes: 5253-kmem_alloc-kmem_zalloc-wont-fail-with-KM_SLEEP.patch
Printable review: 5253-kmem_alloc-kmem_zalloc-wont-fail-with-KM_SLEEP.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc_bitmap.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 2655 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc_io.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
6 lines changed: 0 ins; 6 del; 0 mod; 6718 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/solaris/nsc_raw.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
7 lines changed: 0 ins; 7 del; 0 mod; 846 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/sv/sv.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 2816 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/io/dca.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
10 lines changed: 0 ins; 8 del; 2 mod; 5021 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/io/dca_rng.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
13 lines changed: 0 ins; 11 del; 2 mod; 312 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/crypto/io/dprov.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 9803 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_sys.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/ufs/ufs_acl.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 1 del; 1 mod; 2111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/aac/aac.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 8497 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/arn/arn_phy.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
12 lines changed: 0 ins; 12 del; 0 mod; 439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/beep.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
8 lines changed: 0 ins; 8 del; 0 mod; 509 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/blkdev/blkdev.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
3 lines changed: 0 ins; 2 del; 1 mod; 1773 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/lu/stmf_sbd/sbd.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
3 lines changed: 0 ins; 2 del; 1 mod; 3715 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/pppt/pppt.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 1450 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlc/ql_init.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
13 lines changed: 0 ins; 13 del; 0 mod; 4340 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlc/ql_ioctl.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
41 lines changed: 0 ins; 36 del; 5 mod; 2427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlc/ql_mbx.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
12 lines changed: 0 ins; 11 del; 1 mod; 4853 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlc/ql_nx.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 1967 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlc/ql_xioctl.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
137 lines changed: 0 ins; 134 del; 3 mod; 9123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlge/qlge_flash.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
6 lines changed: 0 ins; 6 del; 0 mod; 1405 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/iwh/iwh.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
5 lines changed: 0 ins; 5 del; 0 mod; 6597 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/iwp/iwp.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
5 lines changed: 0 ins; 5 del; 0 mod; 5418 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/mwl/mwl.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
11 lines changed: 0 ins; 11 del; 0 mod; 4356 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/net80211/net80211_crypto_ccmp.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 479 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/net80211/net80211_crypto_tkip.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 776 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ntxn/unm_nic_init.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
5 lines changed: 0 ins; 5 del; 0 mod; 509 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/pciex/hotplug/pcie_hp.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 1 del; 1 mod; 1298 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/rtw/rtw.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
6 lines changed: 0 ins; 6 del; 0 mod; 3422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_impl.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
3 lines changed: 0 ins; 3 del; 0 mod; 2788 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/pmcs/pmcs_attach.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
5 lines changed: 0 ins; 5 del; 0 mod; 3272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/targets/ses_safte.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
8 lines changed: 0 ins; 8 del; 0 mod; 1170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/hcd/uhci/uhciutil.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
8 lines changed: 0 ins; 6 del; 2 mod; 5028 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/usba/whcdi.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
3 lines changed: 0 ins; 3 del; 0 mod; 2881 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/xge/drv/xgell.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
21 lines changed: 0 ins; 21 del; 0 mod; 2857 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/yge/yge.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 3588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sunddi.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
6 lines changed: 0 ins; 5 del; 1 mod; 10018 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/sec_gss/svc_rpcsec_gss.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
3 lines changed: 0 ins; 3 del; 0 mod; 1921 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/gfx_private/gfxp_devmap.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
5 lines changed: 0 ins; 5 del; 0 mod; 171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/gfx_private/gfxp_pci.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
8 lines changed: 0 ins; 6 del; 2 mod; 341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/dktp/dcdev/dadk.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
9 lines changed: 0 ins; 7 del; 2 mod; 1831 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/drm/i915_gem.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
4 lines changed: 0 ins; 4 del; 0 mod; 2915 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/heci/heci_init.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
8 lines changed: 0 ins; 8 del; 0 mod; 1195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/os/fmsmb.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 1138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/io/pcicfg.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
6 lines changed: 0 ins; 6 del; 0 mod; 6841 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/io/px/px_mmu.c

5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP
2 lines changed: 0 ins; 2 del; 0 mod; 345 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.