Code Review for swapping-v2

Prepared by:Jeff (jeffpc) on 2014-Apr-04 14:37 -0400 EDT
Workspace:/home/jeffpc/illumos/swapping (at 1b13171fb351)
Compare against: master (at 09fadd948f90)
Summary of changes: 2275 lines changed: 0 ins; 2243 del; 32 mod; 100323 unchg
Patch of changes: swapping-v2.patch
Printable review: swapping-v2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/findstack.c

patch fix-mdb
3 lines changed: 0 ins; 3 del; 0 mod; 904 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/findstack.h

patch fix-mdb
3 lines changed: 0 ins; 1 del; 2 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/findstack_subr.c

patch fix-mdb
7 lines changed: 0 ins; 7 del; 0 mod; 415 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/kmem.c

patch fix-mdb
8 lines changed: 0 ins; 8 del; 0 mod; 4373 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/leaky_subr.c

patch sccs-keywords
patch fix-mdb
12 lines changed: 0 ins; 12 del; 0 mod; 912 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/disp.c

patch delete-swapped_lock
patch remove-dead-disp-code
patch remove-useless-var2
patch remove-load-flag
patch remove-on-swapq-flag
patch remove-dont-swap-flag
143 lines changed: 0 ins; 141 del; 2 mod; 2558 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/fss.c

patch delete-t_stime
patch remove-swapenq-flag
patch remove-dont-swap-flag
patch remove-swapinout-class-ops
132 lines changed: 0 ins; 131 del; 1 mod; 2547 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/fx.c

patch delete-t_stime
patch remove-swapinout-class-ops
48 lines changed: 0 ins; 48 del; 0 mod; 1798 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/rt.c

patch remove-dont-swap-flag
patch remove-swapinout-class-ops
49 lines changed: 0 ins; 49 del; 0 mod; 1083 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/sysclass.c

patch sccs-keywords
patch fix-compile
14 lines changed: 0 ins; 14 del; 0 mod; 224 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/sysdc.c

patch remove-swapinout-class-ops
10 lines changed: 0 ins; 10 del; 0 mod; 1307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/thread.c

patch delete-t_stime
patch remove-load-flag
patch remove-dont-swap-flag
2 lines changed: 0 ins; 1 del; 1 mod; 2127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/ts.c

patch delete-t_stime
patch remove-swapenq-flag
patch remove-dont-swap-flag
patch remove-swapinout-class-ops
159 lines changed: 0 ins; 159 del; 0 mod; 2268 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_srv.c

patch remove-dont-swap-flag
2 lines changed: 0 ins; 2 del; 0 mod; 3001 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/clock.c

patch clock-wakeup-remove
38 lines changed: 0 ins; 38 del; 0 mod; 2622 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/condvar.c

patch remove-dont-swap-flag
6 lines changed: 0 ins; 6 del; 0 mod; 815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu.c

patch fix-compile3
patch remove-load-flag
patch remove-on-swapq-flag
21 lines changed: 0 ins; 19 del; 2 mod; 3429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/panic.c

patch remove-dont-swap-flag
1 line changed: 0 ins; 1 del; 0 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sched.c

patch delete-swapped_lock
patch sched-cleanup
patch remove-useless-var2
patch remove-dead-sched-code
patch remove-as_swapout
patch remove-load-flag
patch remove-on-swapq-flag
patch remove-swapenq-flag
patch remove-dont-swap-flag
patch remove-swapinout-class-ops
patch remove-useless-var
849 lines changed: 0 ins; 838 del; 11 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/timers.c

patch remove-load-flag
7 lines changed: 0 ins; 7 del; 0 mod; 1487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/waitq.c

patch remove-dont-swap-flag
5 lines changed: 0 ins; 5 del; 0 mod; 388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/class.h

patch remove-swapinout-class-ops
6 lines changed: 0 ins; 6 del; 0 mod; 225 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/disp.h

patch sccs-keywords
patch remove-load-flag
4 lines changed: 0 ins; 4 del; 0 mod; 183 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/proc.h

patch remove-as_swapout
5 lines changed: 0 ins; 3 del; 2 mod; 815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysinfo.h

patch remove-cpu-stats
4 lines changed: 0 ins; 4 del; 0 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/systm.h

patch clock-wakeup-remove
5 lines changed: 0 ins; 5 del; 0 mod; 499 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/thread.h

patch delete-t_stime
patch delete-swapped_lock
patch remove-load-flag
patch remove-on-swapq-flag
patch remove-swapenq-flag
patch remove-dont-swap-flag
20 lines changed: 0 ins; 20 del; 0 mod; 702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/vmsystm.h

patch sched-cleanup
2 lines changed: 0 ins; 2 del; 0 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/anon.h

patch delete-anon_array_try_enter
2 lines changed: 0 ins; 2 del; 0 mod; 500 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/as.h

patch remove-as_swapout
1 line changed: 0 ins; 1 del; 0 mod; 316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/hat.h

patch vm-cleanup
8 lines changed: 0 ins; 8 del; 0 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg.h

patch sccs-keywords
patch SEGOP_SWAPOUT-delete
4 lines changed: 0 ins; 4 del; 0 mod; 277 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_dev.c

patch SEGOP_SWAPOUT-delete
1 line changed: 0 ins; 1 del; 0 mod; 4100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kmem.c

patch vm-cleanup
1 line changed: 0 ins; 1 del; 0 mod; 1644 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kp.c

patch SEGOP_SWAPOUT-delete
patch remove-dont-swap-flag
10 lines changed: 0 ins; 8 del; 2 mod; 1456 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kpm.c

patch cstyle
patch sccs-keywords
patch SEGOP_SWAPOUT-delete
6 lines changed: 0 ins; 3 del; 3 mod; 336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_map.c

patch SEGOP_SWAPOUT-delete
1 line changed: 0 ins; 1 del; 0 mod; 2353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_spt.c

patch SEGOP_SWAPOUT-delete
10 lines changed: 0 ins; 10 del; 0 mod; 3105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_vn.c

patch SEGOP_SWAPOUT-delete
185 lines changed: 0 ins; 185 del; 0 mod; 9946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vm_anon.c

patch delete-anon_array_try_enter
patch SEGOP_SWAPOUT-delete
39 lines changed: 0 ins; 37 del; 2 mod; 3588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vm_as.c

patch remove-as_swapout
67 lines changed: 0 ins; 67 del; 0 mod; 3611 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/xhat.c

patch sccs-keywords
patch vm-cleanup
61 lines changed: 0 ins; 61 del; 0 mod; 494 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/xhat.h

patch vm-cleanup
10 lines changed: 0 ins; 10 del; 0 mod; 198 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mlsetup.c

patch fix-compile2
1 line changed: 0 ins; 0 del; 1 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/trap.c

patch fix-compile2
1 line changed: 0 ins; 1 del; 0 mod; 2253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/hat_i86.c

patch vm-cleanup
82 lines changed: 0 ins; 82 del; 0 mod; 4381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/vm/seg_mf.c

patch fix-compile4
1 line changed: 0 ins; 1 del; 0 mod; 783 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/syscall.c

patch fix-compile2
3 lines changed: 0 ins; 2 del; 1 mod; 1390 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sfmmu/vm/hat_sfmmu.c

patch vm-cleanup
148 lines changed: 0 ins; 147 del; 1 mod; 15707 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/os/syscall.c

patch fix-compile2
2 lines changed: 0 ins; 2 del; 0 mod; 1231 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/v9/os/v9dep.c

patch sched-cleanup
9 lines changed: 0 ins; 9 del; 0 mod; 1865 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/mlsetup.c

patch fix-compile2
1 line changed: 0 ins; 0 del; 1 mod; 544 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/trap.c

patch fix-compile2
9 lines changed: 0 ins; 9 del; 0 mod; 1956 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/vm/zulu_hat.c

patch vm-cleanup
47 lines changed: 0 ins; 47 del; 0 mod; 1422 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.